lists.arthurdejong.org
RSS feed

nss-pam-ldapd commit: r1128 - nss-pam-ldapd/pam

[Date Prev][Date Next] [Thread Prev][Thread Next]

nss-pam-ldapd commit: r1128 - nss-pam-ldapd/pam



Author: arthur
Date: Tue Jun  1 22:04:11 2010
New Revision: 1128
URL: http://arthurdejong.org/viewvc/nss-pam-ldapd?view=rev&revision=1128

Log:
don't log failure to do nslcd request to user and log authentication errors 
during password change

Modified:
   nss-pam-ldapd/pam/pam.c

Modified: nss-pam-ldapd/pam/pam.c
==============================================================================
--- nss-pam-ldapd/pam/pam.c     Tue Jun  1 21:40:39 2010        (r1127)
+++ nss-pam-ldapd/pam/pam.c     Tue Jun  1 22:04:11 2010        (r1128)
@@ -438,12 +438,7 @@
   else if ((rc==PAM_USER_UNKNOWN)&&cfg.ignore_unknown_user)
     rc=PAM_IGNORE;
   if (rc!=PAM_SUCCESS)
-  {
-    if (rc!=PAM_IGNORE)
-      if (!cfg.no_warn)
-        pam_error(pamh,"LDAP authorization failed");
     return rc;
-  }
   /* check the returned authorisation value */
   if (ctx2.authz!=PAM_SUCCESS)
   {
@@ -571,6 +566,11 @@
       rc=PAM_IGNORE;
     else if ((rc==PAM_USER_UNKNOWN)&&cfg.ignore_unknown_user)
       rc=PAM_IGNORE;
+    /* log error or success */
+    if (rc!=PAM_SUCCESS)
+      pam_syslog(pamh,LOG_NOTICE,"%s; user=%s",pam_strerror(pamh,rc),username);
+    else if (cfg.debug)
+      pam_syslog(pamh,LOG_DEBUG,"authentication succeeded");
     /* TODO: figure out when to return PAM_TRY_AGAIN */
     /* TODO: if password is incorrect (NSLCD_PAM_AUTH_ERR) log that */
     return rc;
--
To unsubscribe send an email to
nss-pam-ldapd-commits-unsubscribe@lists.arthurdejong.org or see
http://lists.arthurdejong.org/nss-pam-ldapd-commits