lists.arthurdejong.org
RSS feed

nss-pam-ldapd commit: r1516 - in nss-pam-ldapd-0.7: . nslcd

[Date Prev][Date Next] [Thread Prev][Thread Next]

nss-pam-ldapd commit: r1516 - in nss-pam-ldapd-0.7: . nslcd



Author: arthur
Date: Wed Aug 24 22:45:23 2011
New Revision: 1516
URL: http://arthurdejong.org/viewvc/nss-pam-ldapd?view=rev&revision=1516

Log:
fix a problem with uninitialised memory while parsing the tls_ciphers option 
(r1471 from development)

Modified:
   nss-pam-ldapd-0.7/   (props changed)
   nss-pam-ldapd-0.7/nslcd/cfg.c

Modified: nss-pam-ldapd-0.7/nslcd/cfg.c
==============================================================================
--- nss-pam-ldapd-0.7/nslcd/cfg.c       Wed Aug 24 22:22:20 2011        (r1515)
+++ nss-pam-ldapd-0.7/nslcd/cfg.c       Wed Aug 24 22:45:23 2011        (r1516)
@@ -5,7 +5,7 @@
 
    Copyright (C) 1997-2005 Luke Howard
    Copyright (C) 2007 West Consulting
-   Copyright (C) 2007, 2008, 2009, 2010 Arthur de Jong
+   Copyright (C) 2007, 2008, 2009, 2010, 2011 Arthur de Jong
 
    This library is free software; you can redistribute it and/or
    modify it under the terms of the GNU Lesser General Public
@@ -415,12 +415,10 @@
                         char **var)
 {
   check_argumentcount(filename,lnr,keyword,(*line!=NULL)&&(**line!='\0'));
-  if ((*var==NULL)||(strcmp(*var,*line)!=0))
-  {
-    /* Note: we have a memory leak here if a single mapping is changed
-             multiple times in one config (deemed not a problem) */
-    *var=xstrdup(*line);
-  }
+  /* Note: we have a memory leak here if a single mapping is changed
+           multiple times in one config (deemed not a problem) */
+  *var=xstrdup(*line);
+  /* mark that we are at the end of the line */
   *line=NULL;
 }
 
-- 
To unsubscribe send an email to
nss-pam-ldapd-commits-unsubscribe@lists.arthurdejong.org or see
http://lists.arthurdejong.org/nss-pam-ldapd-commits