nss-pam-ldapd commit: r1547 - nss-pam-ldapd/nslcd

[Commits of the nss-pam-ldapd project <nss-pam-ldapd-commits [at] lists.arthurdejong.org>]

Author: jhrozek
Date: Fri Sep 30 13:48:21 2011
New Revision: 1547
URL: http://arthurdejong.org/viewvc/nss-pam-ldapd?revision=1547&view=revision

Log:
Use an explicit base of 10 for strtouid()/strtogid()/strtol() calls

Modified:
   nss-pam-ldapd/nslcd/cfg.c
   nss-pam-ldapd/nslcd/group.c
   nss-pam-ldapd/nslcd/passwd.c
   nss-pam-ldapd/nslcd/protocol.c
   nss-pam-ldapd/nslcd/rpc.c
   nss-pam-ldapd/nslcd/service.c
   nss-pam-ldapd/nslcd/shadow.c

Modified: nss-pam-ldapd/nslcd/cfg.c
==============================================================================
--- nss-pam-ldapd/nslcd/cfg.c   Wed Sep 21 20:59:49 2011        (r1546)
+++ nss-pam-ldapd/nslcd/cfg.c   Fri Sep 30 13:48:21 2011        (r1547)
@@ -431,7 +431,7 @@
   
check_argumentcount(filename,lnr,keyword,get_token(line,token,sizeof(token))!=NULL);
   /* check if it is a valid numerical uid */
   errno=0;
-  *var=strtouid(token,&tmp,0);
+  *var=strtouid(token,&tmp,10);
   if ((*token!='\0')&&(*tmp=='\0')&&(errno==0))
     return;
   /* find by name */
@@ -457,7 +457,7 @@
   
check_argumentcount(filename,lnr,keyword,get_token(line,token,sizeof(token))!=NULL);
   /* check if it is a valid numerical gid */
   errno=0;
-  *var=strtogid(token,&tmp,0);
+  *var=strtogid(token,&tmp,10);
   if ((*token!='\0')&&(*tmp=='\0')&&(errno==0))
     return;
   /* find by name */

Modified: nss-pam-ldapd/nslcd/group.c
==============================================================================
--- nss-pam-ldapd/nslcd/group.c Wed Sep 21 20:59:49 2011        (r1546)
+++ nss-pam-ldapd/nslcd/group.c Fri Sep 30 13:48:21 2011        (r1547)
@@ -281,7 +281,7 @@
       else
       {
         errno=0;
-        gids[numgids]=strtogid(gidvalues[numgids],&tmp,0);
+        gids[numgids]=strtogid(gidvalues[numgids],&tmp,10);
         if ((*(gidvalues[numgids])=='\0')||(*tmp!='\0'))
         {
           log_log(LOG_WARNING,"%s: %s: non-numeric",

Modified: nss-pam-ldapd/nslcd/passwd.c
==============================================================================
--- nss-pam-ldapd/nslcd/passwd.c        Wed Sep 21 20:59:49 2011        (r1546)
+++ nss-pam-ldapd/nslcd/passwd.c        Fri Sep 30 13:48:21 2011        (r1547)
@@ -195,7 +195,7 @@
     else
     {
       errno=0;
-      uid=strtouid(values[i],&tmp,0);
+      uid=strtouid(values[i],&tmp,10);
       if ((*(values[i])=='\0')||(*tmp!='\0'))
       {
         log_log(LOG_WARNING,"%s: %s: non-numeric",
@@ -492,7 +492,7 @@
       else
       {
         errno=0;
-        uids[numuids]=strtouid(tmpvalues[numuids],&tmp,0);
+        uids[numuids]=strtouid(tmpvalues[numuids],&tmp,10);
         if ((*(tmpvalues[numuids])=='\0')||(*tmp!='\0'))
         {
           log_log(LOG_WARNING,"%s: %s: non-numeric",
@@ -530,7 +530,7 @@
       return 0;
     }
     errno=0;
-    gid=strtogid(gidbuf,&tmp,0);
+    gid=strtogid(gidbuf,&tmp,10);
     if ((gidbuf[0]=='\0')||(*tmp!='\0'))
     {
       log_log(LOG_WARNING,"%s: %s: non-numeric",

Modified: nss-pam-ldapd/nslcd/protocol.c
==============================================================================
--- nss-pam-ldapd/nslcd/protocol.c      Wed Sep 21 20:59:49 2011        (r1546)
+++ nss-pam-ldapd/nslcd/protocol.c      Fri Sep 30 13:48:21 2011        (r1547)
@@ -144,7 +144,7 @@
                         myldap_get_dn(entry),attmap_protocol_ipProtocolNumber);
   }
   errno=0;
-  proto=(int)strtol(protos[0],&tmp,0);
+  proto=(int)strtol(protos[0],&tmp,10);
   if ((*(protos[0])=='\0')||(*tmp!='\0'))
   {
     log_log(LOG_WARNING,"%s: %s: non-numeric",

Modified: nss-pam-ldapd/nslcd/rpc.c
==============================================================================
--- nss-pam-ldapd/nslcd/rpc.c   Wed Sep 21 20:59:49 2011        (r1546)
+++ nss-pam-ldapd/nslcd/rpc.c   Fri Sep 30 13:48:21 2011        (r1547)
@@ -145,7 +145,7 @@
                         myldap_get_dn(entry),attmap_rpc_oncRpcNumber);
   }
   errno=0;
-  number=(int)strtol(numbers[0],&tmp,0);
+  number=(int)strtol(numbers[0],&tmp,10);
   if ((*(numbers[0])=='\0')||(*tmp!='\0'))
   {
     log_log(LOG_WARNING,"%s: %s: non-numeric",

Modified: nss-pam-ldapd/nslcd/service.c
==============================================================================
--- nss-pam-ldapd/nslcd/service.c       Wed Sep 21 20:59:49 2011        (r1546)
+++ nss-pam-ldapd/nslcd/service.c       Fri Sep 30 13:48:21 2011        (r1547)
@@ -173,7 +173,7 @@
                         myldap_get_dn(entry),attmap_service_ipServicePort);
   }
   errno=0;
-  port=(int)strtol(ports[0],&tmp,0);
+  port=(int)strtol(ports[0],&tmp,10);
   if ((*(ports[0])=='\0')||(*tmp!='\0'))
   {
     log_log(LOG_WARNING,"%s: %s: non-numeric value",

Modified: nss-pam-ldapd/nslcd/shadow.c
==============================================================================
--- nss-pam-ldapd/nslcd/shadow.c        Wed Sep 21 20:59:49 2011        (r1546)
+++ nss-pam-ldapd/nslcd/shadow.c        Fri Sep 30 13:48:21 2011        (r1547)
@@ -130,7 +130,7 @@
     strncpy(buffer,date,l);
     buffer[l]='\0';
     errno=0;
-    value=strtol(date,&tmp,0);
+    value=strtol(date,&tmp,10);
     if ((*date=='\0')||(*tmp!='\0'))
     {
       log_log(LOG_WARNING,"%s: %s: non-numeric",dn,attr);
@@ -146,7 +146,7 @@
        and some value that needs to be added */
   }
   errno=0;
-  value=strtol(date,&tmp,0);
+  value=strtol(date,&tmp,10);
   if ((*date=='\0')||(*tmp!='\0'))
   {
     log_log(LOG_WARNING,"%s: %s: non-numeric",dn,attr);
@@ -169,7 +169,7 @@
   if (tmpvalue==NULL) \
     tmpvalue=""; \
   errno=0; \
-  var=strtol(tmpvalue,&tmp,0); \
+  var=strtol(tmpvalue,&tmp,10); \
   if ((*(tmpvalue)=='\0')||(*tmp!='\0')) \
   { \
     log_log(LOG_WARNING,"%s: %s: non-numeric", \
-- 
To unsubscribe send an email to
nss-pam-ldapd-commits-unsubscribe@lists.arthurdejong.org or see
http://lists.arthurdejong.org/nss-pam-ldapd-commits/