nss-pam-ldapd commit: r1900 - nss-pam-ldapd/nslcd

[Commits of the nss-pam-ldapd project <nss-pam-ldapd-commits [at] lists.arthurdejong.org>]

Author: arthur
Date: Sat Jan  5 23:55:56 2013
New Revision: 1900
URL: http://arthurdejong.org/viewvc/nss-pam-ldapd?revision=1900&view=revision

Log:
change ethernet address formatting from FIXME to note

Modified:
   nss-pam-ldapd/nslcd/ether.c

Modified: nss-pam-ldapd/nslcd/ether.c
==============================================================================
--- nss-pam-ldapd/nslcd/ether.c Sat Jan  5 23:49:39 2013        (r1899)
+++ nss-pam-ldapd/nslcd/ether.c Sat Jan  5 23:55:56 2013        (r1900)
@@ -5,7 +5,7 @@
 
    Copyright (C) 1997-2005 Luke Howard
    Copyright (C) 2006 West Consulting
-   Copyright (C) 2006, 2007, 2009, 2010, 2011, 2012 Arthur de Jong
+   Copyright (C) 2006, 2007, 2009, 2010, 2011, 2012, 2013 Arthur de Jong
 
    This library is free software; you can redistribute it and/or
    modify it under the terms of the GNU Lesser General Public
@@ -78,10 +78,10 @@
 static int mkfilter_ether_byether(const char *addrstr,
                                   char *buffer, size_t buflen)
 {
-  /* FIXME: this has a bug when the directory has 01:00:0e:...
-     and we're looking for 1:0:e:... (leading zeros) */
+  /* Note: this only works if the address in LDAP has the preferred minimal
+     representation (e.g. 1:0:e:...) and not with extra leading zeros
+     (e.g. 01:00:0e:...) */
   /* there should be no characters that need escaping */
-  /* build filter */
   return mysnprintf(buffer, buflen, "(&%s(%s=%s))",
                     ether_filter, attmap_ether_macAddress, addrstr);
 }
-- 
To unsubscribe send an email to
nss-pam-ldapd-commits-unsubscribe@lists.arthurdejong.org or see
http://lists.arthurdejong.org/nss-pam-ldapd-commits/