nss-pam-ldapd branch master updated. 0.9.1-5-g07a8170
[
Date Prev][
Date Next]
[
Thread Prev][
Thread Next]
nss-pam-ldapd branch master updated. 0.9.1-5-g07a8170
- From: Commits of the nss-pam-ldapd project <nss-pam-ldapd-commits [at] lists.arthurdejong.org>
- To: nss-pam-ldapd-commits [at] lists.arthurdejong.org
- Reply-to: nss-pam-ldapd-users [at] lists.arthurdejong.org
- Subject: nss-pam-ldapd branch master updated. 0.9.1-5-g07a8170
- Date: Sat, 31 Aug 2013 23:34:22 +0200 (CEST)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "nss-pam-ldapd".
The branch, master has been updated
via 07a8170330cd289ee9cba0ce5d579d2695e64b8f (commit)
from 4897033a912d513be82268b20fe73190684960fe (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://arthurdejong.org/git/nss-pam-ldapd/commit/?id=07a8170330cd289ee9cba0ce5d579d2695e64b8f
commit 07a8170330cd289ee9cba0ce5d579d2695e64b8f
Author: Arthur de Jong <arthur@arthurdejong.org>
Date: Sat Aug 31 22:27:51 2013 +0200
Fix buffer overflow on interupted read
The tio_read() function will read past its buffer and return garbadge to
the calling function if the call to read() was interrupted by a signal.
The likelyhood of read() being interupted is low because previously a
call to poll() has determined that data is available to be read.
Thanks to John Sullivan for pointing this out.
See:
https://bugzilla.redhat.com/show_bug.cgi?id=1003011
diff --git a/common/tio.c b/common/tio.c
index 3b81a55..f28ac91 100644
--- a/common/tio.c
+++ b/common/tio.c
@@ -277,8 +277,8 @@ int tio_read(TFILE *fp, void *buf, size_t count)
}
else if ((rv < 0) && (errno != EINTR) && (errno != EAGAIN))
return -1; /* something went wrong with the read */
- /* skip the read part in the buffer */
- fp->readbuffer.len = rv;
+ else if (rv > 0)
+ fp->readbuffer.len = rv; /* skip the read part in the buffer */
#ifdef DEBUG_TIO_STATS
fp->bytesread += rv;
#endif /* DEBUG_TIO_STATS */
-----------------------------------------------------------------------
Summary of changes:
common/tio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
hooks/post-receive
--
nss-pam-ldapd
--
To unsubscribe send an email to
nss-pam-ldapd-commits-unsubscribe@lists.arthurdejong.org or see
http://lists.arthurdejong.org/nss-pam-ldapd-commits/
- nss-pam-ldapd branch master updated. 0.9.1-5-g07a8170,
Commits of the nss-pam-ldapd project