nslcd/nslcd.c main() return value?

["Moravec, Stanislav (ERT)" <stanislav.moravec [at] hpe.com>]

Hello all,

is there any good reason for main() of nslcd to return ERR_FAILURE?

https://github.com/arthurdejong/nss-pam-ldapd/blob/master/nslcd/nslcd.c#L897

It leads to a failure when doing clean stop via "systemctl stop nslcd".

# systemctl status nslcd
● nslcd.service - Naming services LDAP client daemon.
   Loaded: loaded (/usr/lib/systemd/system/nslcd.service; disabled; vendor 
preset: disabled)
   Active: failed (Result: exit-code) since Mon 2017-02-06 12:22:00 CET; 1s ago
  Process: 31316 ExecStart=/usr/sbin/nslcd (code=exited, status=0/SUCCESS)
 Main PID: 31317 (code=exited, status=1/FAILURE)

The stop sends SIGTERM, to cleanly stop the daemon, but that behaves as if it 
ended 
with an error. Adjusted service setup to access ret val of 1 as success would
hide real errors, so it's not a good option either.

Anyone?

Thanks
Stan Moravec
HPE
        

-- 
To unsubscribe send an email to
nss-pam-ldapd-users-unsubscribe@lists.arthurdejong.org or see
https://lists.arthurdejong.org/nss-pam-ldapd-users/