lists.arthurdejong.org
RSS feed

python-stdnum branch master updated. 1.20-28-gae0d86c

[Date Prev][Date Next] [Thread Prev][Thread Next]

python-stdnum branch master updated. 1.20-28-gae0d86c



This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "python-stdnum".

The branch, master has been updated
       via  ae0d86cf0063afa69bc02ecdb930ab2fb5561748 (commit)
       via  dcd7fa6f9bc0881d6dcc1f7814cfa6e498166de0 (commit)
      from  852515c92c97739df1a16ffe3ddac91c9cf03e38 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://arthurdejong.org/git/python-stdnum/commit/?id=ae0d86cf0063afa69bc02ecdb930ab2fb5561748

commit ae0d86cf0063afa69bc02ecdb930ab2fb5561748
Author: Arthur de Jong <arthur@arthurdejong.org>
Date:   Thu Mar 27 14:19:10 2025 +0100

    Ignore test failures from www.dgii.gov.do
    
    There was a change in the SOAP service and there is a new URL. However,
    the API has changed and seems to require authentication.
    
    We ignore test failures for now but unless a solution is found the DGII
    validation will be removed.
    
    See: https://github.com/arthurdejong/python-stdnum/pull/462
    See: https://github.com/arthurdejong/python-stdnum/issues/461

diff --git a/tests/test_do_cedula.py b/tests/test_do_cedula.py
index b1037c1..4141c30 100644
--- a/tests/test_do_cedula.py
+++ b/tests/test_do_cedula.py
@@ -36,6 +36,14 @@ class TestDGII(unittest.TestCase):
     """Test the web services provided by the the Dirección General de
     Impuestos Internos (DGII), the Dominican Republic tax department."""
 
+    # Theses tests currently fail because the SOAP service at
+    # https://www.dgii.gov.do/wsMovilDGII/WSMovilDGII.asmx?WSDL
+    # is no longer available. There is a new one at
+    # https://www.dgii.gov.do/ventanillaunica/ventanillaunica.asmx?WSDL
+    # but it has a different API and seems to require authentication.
+    # See https://github.com/arthurdejong/python-stdnum/pull/462
+    # and https://github.com/arthurdejong/python-stdnum/issues/461
+    @unittest.expectedFailure
     def test_check_dgii(self):
         """Test stdnum.do.cedula.check_dgii()"""
         # Test a normal valid number
diff --git a/tests/test_do_rnc.py b/tests/test_do_rnc.py
index 8d93f90..5c1531b 100644
--- a/tests/test_do_rnc.py
+++ b/tests/test_do_rnc.py
@@ -36,6 +36,14 @@ class TestDGII(unittest.TestCase):
     """Test the web services provided by the the Dirección General de
     Impuestos Internos (DGII), the Dominican Republic tax department."""
 
+    # Theses tests currently fail because the SOAP service at
+    # https://www.dgii.gov.do/wsMovilDGII/WSMovilDGII.asmx?WSDL
+    # is no longer available. There is a new one at
+    # https://www.dgii.gov.do/ventanillaunica/ventanillaunica.asmx?WSDL
+    # but it has a different API and seems to require authentication.
+    # See https://github.com/arthurdejong/python-stdnum/pull/462
+    # and https://github.com/arthurdejong/python-stdnum/issues/461
+    @unittest.expectedFailure
     def test_check_dgii(self):
         """Test stdnum.do.rnc.check_dgii()"""
         # Test a normal valid number
@@ -58,6 +66,14 @@ class TestDGII(unittest.TestCase):
         result = rnc.check_dgii('132070801')
         self.assertEqual(result['rnc'], '132070801')
 
+    # Theses tests currently fail because the SOAP service at
+    # https://www.dgii.gov.do/wsMovilDGII/WSMovilDGII.asmx?WSDL
+    # is no longer available. There is a new one at
+    # https://www.dgii.gov.do/ventanillaunica/ventanillaunica.asmx?WSDL
+    # but it has a different API and seems to require authentication.
+    # See https://github.com/arthurdejong/python-stdnum/pull/462
+    # and https://github.com/arthurdejong/python-stdnum/issues/461
+    @unittest.expectedFailure
     def test_search_dgii(self):
         """Test stdnum.do.rnc.search_dgii()"""
         # Search for some existing companies

https://arthurdejong.org/git/python-stdnum/commit/?id=dcd7fa6f9bc0881d6dcc1f7814cfa6e498166de0

commit dcd7fa6f9bc0881d6dcc1f7814cfa6e498166de0
Author: Arthur de Jong <arthur@arthurdejong.org>
Date:   Thu Mar 27 14:14:07 2025 +0100

    Drop more Python 2.7 compatibility code

diff --git a/tests/test_do_rnc.py b/tests/test_do_rnc.py
index 5eebeeb..8d93f90 100644
--- a/tests/test_do_rnc.py
+++ b/tests/test_do_rnc.py
@@ -36,12 +36,6 @@ class TestDGII(unittest.TestCase):
     """Test the web services provided by the the Dirección General de
     Impuestos Internos (DGII), the Dominican Republic tax department."""
 
-    def setUp(self):
-        """Prepare the test."""
-        # For Python 2.7 compatibility
-        if not hasattr(self, 'assertRegex'):
-            self.assertRegex = self.assertRegexpMatches
-
     def test_check_dgii(self):
         """Test stdnum.do.rnc.check_dgii()"""
         # Test a normal valid number

-----------------------------------------------------------------------

Summary of changes:
 tests/test_do_cedula.py |  8 ++++++++
 tests/test_do_rnc.py    | 22 ++++++++++++++++------
 2 files changed, 24 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
python-stdnum