lists.arthurdejong.org
RSS feed

Re: Japanese Individual Number (IN)

[Date Prev][Date Next] [Thread Prev][Thread Next]

Re: Japanese Individual Number (IN)



Hi Luca,

On Fri, 2025-04-04 at 10:14 +0200, Luca Sicurello wrote:
> First of all I would like thank you for this amazing library: it has 
> saved me countless hours checking taxpayer identification numbers of 
> various countries!

Thanks and sorry for not responding sooner.

> In the attachment you will find a test for the Japanese Individual 
> Number. I have tested my code on some numbers send by my clients and 
> some example numbers I found online.

Thanks. I've merged it with very little modifications in 
https://arthurdejong.org/git/python-stdnum/commit/?id=fca47b00c63f0fd5de202029fd648c9f44c6cdf2

If it is possible to provide the test numbers I can include them in the
tes suite (but since these are personal numbers I understand that that
may be difficult).

> I would like to contribute in the future (I have some test already
> coded that have to be reformatted), so any comments or feedback would
> be of great help.

I only made a few minor changes so these kind of contributions are
fine. Some people prefer to use Github for contributions but
contributions by email are also fine.

General contribution notes are here:
https://arthurdejong.org/git/python-stdnum/tree/CONTRIBUTING.md

Thanks,

-- 
-- arthur - arthur@arthurdejong.org - https://arthurdejong.org/ --