RSS feed

Re: shadow.c

[Date Prev][Date Next] [Thread Prev][Thread Next]

Re: shadow.c

On Fri, 2014-01-24 at 12:06 -0700, Joshua Shire wrote:
> Line 135 in shadow.c should probably read:
>     value = strtol(buffer, &tmp, 10);  
>  As opposed to:
>     value = strtol(date, &tmp, 10);
> As I understand it, we read the date into the buffer to the specified
> length to get it to the Unix time  (e.g. seconds) from its AD value of
> nanoseconds, then convert it to days for shadow. If we use date rather
> than buffer we end up trying to convert the nanosecond value.

Thanks for pointing this out and fixing this. I've merged your pull
request (with a slight formatting change the the commit message).


-- arthur - - --
To unsubscribe send an email to or see