lists.arthurdejong.org
RSS feed

Re: [PATCH] warnings cleanup: size_t should be formatted %lu rather than %d

[Date Prev][Date Next] [Thread Prev][Thread Next]

Re: [PATCH] warnings cleanup: size_t should be formatted %lu rather than %d



Hi Tim,

I've integrated some bits of your patch to improve portability. Thanks.

I did notice that nss/uw7nss_compat.c is missing from the patch.

I'm not 100% sure I can merge all the changes though. There seem to be a
few license issues and I have no way to test it so I can't easily
support it.

On Mon, 2015-03-16 at 21:15 -0700, Tim Rice wrote:
> It was my impression that the CLOCK_MONOTONIC define was invented as
> part of clock_gettime() but OK, bad example. If I move past tio.c by
> adding a -DCLOCK_MONOTONIC=4 it becomes clear.
> ........
> Making all in nslcd
> gmake[2]: Entering directory 
> `/usr/local/src/networking/nss-pam-ldapd-0.9.4/nslcd'
> cc  -O -Kthread,alloca,pentium_pro -Dvsnprintf=_xvsnprintf 
> -Dsnprintf=_xsnprintf  -L/opt/lib -o nslcd nslcd.o log.o daemonize.o common.o 
> myldap.o cfg.o attmap.o nsswitch.o invalidator.o config.o alias.o ether.o 
> group.o host.o netgroup.o network.o passwd.o protocol.o rpc.o service.o 
> shadow.o pam.o usermod.o ../common/libtio.a ../common/libdict.a 
> ../common/libexpr.a ../compat/libcompat.a -lldap_r -lsocket   -lsocket 
> Undefined                     first referenced
> symbol                            in file
> clock_gettime                       libtio.a(tio.o)
> UX:ld: ERROR: Symbol referencing errors. No output written to nslcd
> gmake[2]: *** [nslcd] Error 1
> ........
> 
> And no, clock_gettime() is not hiding in some other lib.

Ok, some replacement probably needs to be implemented using AC_REPLACE_FUNCS().

> I would be very surprised to find a dlopen() implimentation that does
> not work with the full path name to the lib.

The use of dlopen() in disable_nss_ldap() is mean to load the NSS module
from the loader search path. This means that if the incorrect NSS module
is in the search path nslcd will complain.

Thanks,

-- 
-- arthur - arthur@arthurdejong.org - http://arthurdejong.org/ --
-- 
To unsubscribe send an email to
nss-pam-ldapd-users-unsubscribe@lists.arthurdejong.org or see
http://lists.arthurdejong.org/nss-pam-ldapd-users/