lists.arthurdejong.org
RSS feed

Re: Erros Compiling nss-pam-ldapd on Solaris 10/x86

[Date Prev][Date Next] [Thread Prev][Thread Next]

Re: Erros Compiling nss-pam-ldapd on Solaris 10/x86



On Tue, 2010-09-28 at 15:46 -0700, Ted Cheng wrote:
> I have attached a new protocols.c which includes one error handling
> bug fix, please see below. If you have not integrated the file, please
> use this one, instead.

Thanks for the update. I'm in the process of merging the changes. I'm
first working on updating the code to match the current SVN version
(some structural changes were already made to improve portability).

I've trimmed down ldap-nss.h to the things we actually use from it and
have cleaned out some more files. Also, I want to see if I can make the
changes easier to read. Perhaps work it a little toward the solution
that FreeBSD uses [1].

Since the _nss_ldap_*_r() functions aren't exported by that name anyway
perhaps it isn't needed to rename them to _nss_nslcd_*_r()? Another
solution would be to rework the NSS_BY* and NSS_{SET,GET,END}ENT marcos
so they can be easily fitted inside the functions with just the 
  nss_status_t _nss_ldap_*_r(nss_backend_t *be,void *args)
signature.

Having something like:
  #ifdef NSS_FLAVOUR_GLIBC
  #ifdef NSS_FLAVOUR_SOLARIS
  #ifdef NSS_FLAVOUR_FREEBSD
could perhaps also work. I would rather have some of those flavour
blocks at the end of each nss file than those ifdefs scattered
throughout the module.

Anyway, attached is a patch against SVN r1227 of the merging work I've
done so far. Please let me know if I terribly broke anything already. It
currently doesn't correctly compile on Linux though (I think the linker
is called with incorrect options).

I'm going to continue with cleaning things up (I want to get rid of
ldap-nss.h altogether) and perhaps working it towards the clearer
separation of libc-specific hooks.

Perhaps I should create a branch in SVN with this code. I can provide
you with commit access if you like so perhaps we can work on it together
if you like. What do you think?

[1] http://www.freshports.org/net/nss-pam-ldapd/

-- 
-- arthur - arthur@arthurdejong.org - http://arthurdejong.org --

Attachment: solaris-support-by-symas.patch
Description: Text Data

--
To unsubscribe send an email to
nss-pam-ldapd-users-unsubscribe@lists.arthurdejong.org or see
http://lists.arthurdejong.org/nss-pam-ldapd-users