lists.arthurdejong.org
RSS feed

Re: send returns EPIPE when requesting a large group

[Date Prev][Date Next] [Thread Prev][Thread Next]

Re: send returns EPIPE when requesting a large group



On Thu, 2012-03-15 at 12:20 +0100, Jakub Hrozek wrote:
> Actually, I think I see one bug:
> @@ -147,6 +147,7 @@ nss_status_t nss_ldap_destructor(nss_backend_t *be,void 
> UNUSED(*args));
>    retv=readfn; \
>    /* close socket and we're done */ \
>    if ((retv==NSS_STATUS_SUCCESS)||(retv==NSS_STATUS_TRYAGAIN)) \
> +    (void)tio_skip(fp,0); /* read any buffered data */ \
>      (void)tio_close(fp); \
>    return retv;
> 
> I think the whole if() statement should be enclosed in curly braces:
> -  if ((retv==NSS_STATUS_SUCCESS)||(retv==NSS_STATUS_TRYAGAIN)) \
> +  if ((retv==NSS_STATUS_SUCCESS)||(retv==NSS_STATUS_TRYAGAIN)) { \
> +    (void)tio_skip(fp,0); /* read any buffered data */ \
>      (void)tio_close(fp); \
> +  } \

Thanks. I've fixed it in r1638. That's what you get when programming in
Python too much ;)

-- 
-- arthur - arthur@arthurdejong.org - http://arthurdejong.org --
-- 
To unsubscribe send an email to
nss-pam-ldapd-users-unsubscribe@lists.arthurdejong.org or see
http://lists.arthurdejong.org/nss-pam-ldapd-users/